Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make title bar opaque when in full screen mode without tabs #3860

Merged

Conversation

jotaemepereira
Copy link
Collaborator

@jotaemepereira jotaemepereira commented Feb 11, 2025

Task/Issue URL: https://app.asana.com/0/1204006570077678/1209339803211451
Tech Design URL:
CC:

Description:

Make title bar opaque when in full screen mode without tabs

Before After
before after

Steps to test this PR:

  1. Open the browser and open Asana
  2. Go to the View menu and deselect Show Tabs and Bookmarks Bar in Full screen
  3. Enter full screen mode
  4. Hover over the top
  5. The title bar should be opaque

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@jotaemepereira jotaemepereira changed the base branch from main to release/1.126.0 February 11, 2025 12:51
@jotaemepereira jotaemepereira requested a review from ayoy February 11, 2025 12:52
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @jotaemepereira!

@jotaemepereira jotaemepereira merged commit 544bcb2 into release/1.126.0 Feb 11, 2025
35 checks passed
@jotaemepereira jotaemepereira deleted the juan/opaque-title-bar-when-on-full-screen-mode branch February 11, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants